msglist: Rename (unknown channel) and (unknown user)#2039
msglist: Rename (unknown channel) and (unknown user)#2039MritunjayTiwari14 wants to merge 1 commit intozulip:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes parentheses from the "unknown channel" and "unknown user" labels to align with mainstream app UI conventions (iPhone, Truecaller, WhatsApp), which use plain fallback labels without parentheses.
- Removed parentheses from "unknown channel" and "unknown user" strings
- Updated main localization file and all generated localization files
Reviewed changes
Copilot reviewed 1 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| assets/l10n/app_en.arb | Updated source English localization strings for unknown channel and user names |
| lib/generated/l10n/zulip_localizations.dart | Updated documentation comments for the generated localization methods |
| lib/generated/l10n/zulip_localizations_en.dart | Updated English localization implementation |
| lib/generated/l10n/zulip_localizations_ar.dart | Updated Arabic localization implementation |
| lib/generated/l10n/zulip_localizations_el.dart | Updated Greek localization implementation |
| lib/generated/l10n/zulip_localizations_es.dart | Updated Spanish localization implementation |
| lib/generated/l10n/zulip_localizations_fr.dart | Updated French localization implementation |
| lib/generated/l10n/zulip_localizations_he.dart | Updated Hebrew localization implementation |
| lib/generated/l10n/zulip_localizations_hu.dart | Updated Hungarian localization implementation |
| lib/generated/l10n/zulip_localizations_nb.dart | Updated Norwegian Bokmål localization implementation |
| lib/generated/l10n/zulip_localizations_sk.dart | Updated Slovak localization implementation |
| lib/generated/l10n/zulip_localizations_zh.dart | Updated Chinese localization implementation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| }, | ||
| "unknownUserName": "(unknown user)", | ||
| "unknownUserName": "unknown user", |
There was a problem hiding this comment.
Inconsistent capitalization: unknownChannelName is capitalized as "Unknown channel" while unknownUserName is lowercase as "unknown user". For consistency, both should use the same capitalization style. Consider changing this to "Unknown user" to match "Unknown channel".
| "unknownUserName": "unknown user", | |
| "unknownUserName": "Unknown user", |
MritunjayTiwari14
force-pushed
the
issue-2035
branch
from
1daccb9 to
4eefb34
Compare
|
This implementation changes these strings everywhere they appear. My intention with #2035 was just to change the appearance in the app bar on the message list; I've just added a note in the issue description to make this clear. That targeted change might be somewhat finnicky to get right, and the issue doesn't have the "help wanted" label—and is milestoned "MXB: Future"—so I'll go ahead and close this to focus our effort on current priorities. |
Fixes #2035.
After investigation of several mainstream app and their UI like IPhone's Phone UI(caller id display), Truecaller(for hidden and private numbers) and Whatsapp(For showing Unknown caller's name), they uses plain fallback label like “Unknown …” (no parentheses).